Skip to content

OSDOCS-12848: Added /etc/resolv.conf modification to resolve DNS conn… #91520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS-12848: Added /etc/resolv.conf modification to resolve DNS conn… #91520

wants to merge 1 commit into from

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Apr 2, 2025 •
edited
Loading

Version(s):
4.19

Issue:
OSDOCS-12848

Link to docs preview:

  • SME has approved this change (Mat K).
  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-12848 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

…ect issues

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-12848 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.19

Issue:
OSDOCS-12848

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 2, 2025 •
edited
Loading

🤖 Tue May 06 11:11:44 - Prow CI generated the docs preview:

https://91520--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/k8s_nmstate/k8s-nmstate-troubleshooting-node-network.html
https://91520--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/k8s-nmstate-about-the-k8s-nmstate-operator.html

@dfitzmau dfitzmau force-pushed the OSDOCS-12848 branch 2 times, most recently from 5d601bd to a95deab Compare April 3, 2025 13:39
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Apr 3, 2025
View reviewed changes
modules/k8s-nmstate-deploying-nmstate-CLI.adoc Outdated
@@ -92,6 +92,23 @@ metadata:
EOF
----

. Optional: In the event that your cluster enters a disconnected environment becuase of DNS connectivity issues, you can add the following DNS hostname configuration to the `NMState` CRD to build in health checks that can resolve these issues:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.TermsErrors: Use 'in case', 'if', or 'when' rather than 'In the event'. For more information, see RedHat.TermsErrors.

@dfitzmau dfitzmau force-pushed the OSDOCS-12848 branch 2 times, most recently from 2af6f2d to dee3de2 Compare April 3, 2025 13:53
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-12848 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.19

Issue:
OSDOCS-12848

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-12848 branch 2 times, most recently from a27133f to 21fa5f0 Compare April 3, 2025 15:15
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-12848 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.19

Issue:
OSDOCS-12848

Link to docs preview:

  • SME has approved this change (Mat K).
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-12848 branch 4 times, most recently from ae6be20 to 3b91b80 Compare April 30, 2025 10:52
@mkowalski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2025
@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label May 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-12848 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.19

Issue:
OSDOCS-12848

Link to docs preview:

  • SME has approved this change (Mat K).
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-12848 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.19

Issue:
OSDOCS-12848

Link to docs preview:

  • SME has approved this change (Mat K).
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@michaelryanpeter
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 2, 2025
michaelryanpeter
michaelryanpeter reviewed May 2, 2025
View reviewed changes
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits, a question about applying the CRD to the cluster, and an out-of-scope concern re: eventual DITA migration.

/label peer-review-done
/remove-label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 2, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 6, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 6, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkowalski mkowalski mkowalski left review comments

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@mkowalski mkowalski

Labels
branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @mkowalski @michaelryanpeter @ocpdocs-vale-bot